Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Optional[T] and Union[T, None] with T | None #495

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Replace Optional[T] and Union[T, None] with T | None #495

wants to merge 5 commits into from

Conversation

yangdanny97
Copy link

@yangdanny97 yangdanny97 commented Nov 18, 2024 •
edited
Loading

Summary

The pipe syntax for unions introduced in PEP604 is more concise than Optional, but it only works in Python 3.10+

This PR updates the rule replacing Union[T | None] with Optional[T] to replace both with T | None.

Test Plan

make

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
@yangdanny97 yangdanny97 mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyreese amyreese Awaiting requested review from amyreese amyreese is a code owner

@zsol zsol Awaiting requested review from zsol zsol is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangdanny97 @facebook-github-bot