Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Class,Function}Def.name considered LOAD by ExpressionContextProvider #393

Closed
cdonovick opened this issue Sep 24, 2020 · 1 comment · Fixed by #394
Closed

{Class,Function}Def.name considered LOAD by ExpressionContextProvider #393

cdonovick opened this issue Sep 24, 2020 · 1 comment · Fixed by #394

Comments

@cdonovick
Copy link
Contributor

The names of class and functions seem more naturally a STORE as they introduce a name.
@cdonovick cdonovick mentioned this issue Sep 24, 2020
Merged
@jimmylai
Copy link
Contributor

This makes sense to be a STORE.
In AST, the name of FunctionDef and ClassDef is just a str instead of a Name, which we don't have consistency issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide STORE for {Class,Function}Def.name in ExpressionContextProvider cdonovick/LibCST
2 participants
@jimmylai @cdonovick