Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent import numba vs. numba_dpex #847

Closed
2 of 3 tasks
samaid opened this issue Dec 12, 2022 · 1 comment
Closed
2 of 3 tasks

Consistent import numba vs. numba_dpex #847

samaid opened this issue Dec 12, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request user User submitted issue

Comments

@samaid
Copy link
Contributor

samaid commented Dec 12, 2022

The usage model needs to be consistent. Earlier the approach was to import numba and enable numba_dpex if inputs are usm ndarray.

Lately we revised the approach, and enable numba_dpex explicitly via import. By going this route, the implementation is numba_dpex need to be self-contained, and alias necessary attributes from numba.

The goal is to have a model that minimizes code changes by going from CPU script to heterogeneous script. It means in particular that we have to avoid situations when user needs to import both numba and numba_dpex.

Examples of aliases needed in numba_dpex

@samaid samaid added the enhancement New feature or request label Dec 12, 2022
@mingjie-intel mingjie-intel added the user User submitted issue label Feb 26, 2023
@diptorupd
Copy link
Collaborator

vectorize decorator has been removed and no longer supported (refer #1298, #1299). The rest of the decorators are ported to numba_dpex namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user User submitted issue
Projects
None yet
Development

No branches or pull requests

3 participants