Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add lower function #1006

Closed
wants to merge 1 commit into from
Closed

WIP: Add lower function #1006

wants to merge 1 commit into from

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 17, 2023

Numba added lower as an argument to some functions.

Few more changes required, since this part of code does not work anymore (numba_dpex/core/passes/lowerer.py:1423):

                self.cpu_lower.context.lower_extensions[
                    parfor.Parfor
                ] = _lower_parfor_parallel
AttributeError: Failed in dpex_offload_nopython mode pipeline (step: Custom Lowerer with auto-offload support)
E                'CPUContext' object has no attribute 'lower_extensions'

#1000

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa force-pushed the fix/add_lower_function branch 2 times, most recently from f3a6517 to ded0c8c Compare April 17, 2023 21:50
@ZzEeKkAa ZzEeKkAa force-pushed the fix/add_lower_function branch from ded0c8c to 44b81c0 Compare April 17, 2023 21:50
@ZzEeKkAa ZzEeKkAa changed the title Add lower function WIP: Add lower function Apr 17, 2023
@diptorupd
Copy link
Contributor

Superseded by #1030

@diptorupd diptorupd closed this May 19, 2023
@diptorupd diptorupd deleted the fix/add_lower_function branch May 19, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants