New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and organize gdb tests #1224

Merged

ZzEeKkAa merged 11 commits into IntelPython:main from roxx30198:tests_gdb

Mar 22, 2024

Contributor

roxx30198 commented Nov 18, 2023 •

edited

Loading

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?

Corrected the currently failing tests in tests/debugging also improved examples code.
Closes: #1216

roxx30198 requested review from diptorupd and ZzEeKkAa

November 18, 2023 18:13

roxx30198 self-assigned this

roxx30198 added the tests label

roxx30198 marked this pull request as draft

November 20, 2023 16:08

roxx30198 force-pushed the tests_gdb branch 10 times, most recently from 817e780 to c191a70 Compare

November 25, 2023 02:25

roxx30198 force-pushed the tests_gdb branch 2 times, most recently from a728d43 to c1d85f3 Compare

November 30, 2023 18:54

roxx30198 marked this pull request as ready for review

November 30, 2023 18:57

roxx30198 force-pushed the tests_gdb branch 2 times, most recently from 5467fee to cc98013 Compare

November 30, 2023 21:28

diptorupd force-pushed the tests_gdb branch from cc98013 to 1d4cde5 Compare

December 5, 2023 19:06

roxx30198 force-pushed the tests_gdb branch 2 times, most recently from 4d14999 to dbead26 Compare

December 9, 2023 00:32

ZzEeKkAa reviewed

View reviewed changes

numba_dpex/examples/debug/side-by-side.py Outdated Show resolved Hide resolved

ZzEeKkAa reviewed

View reviewed changes

numba_dpex/tests/debugging/test_breakpoints.py Outdated Show resolved Hide resolved

ZzEeKkAa reviewed

View reviewed changes

numba_dpex/tests/debugging/test_info.py Outdated Show resolved Hide resolved

ZzEeKkAa reviewed

View reviewed changes

numba_dpex/tests/debugging/test_info.py Outdated Show resolved Hide resolved

ZzEeKkAa reviewed

View reviewed changes

numba_dpex/tests/debugging/test_info.py Outdated Show resolved Hide resolved

ZzEeKkAa suggested changes

View reviewed changes

Contributor

ZzEeKkAa left a comment

Thank you! These changes are really good, just left few comments to make it cleaner.

roxx30198 force-pushed the tests_gdb branch from dbead26 to 33bbd1c Compare

December 11, 2023 21:19

ZzEeKkAa force-pushed the tests_gdb branch from 8978054 to 51f45bb Compare

March 21, 2024 16:32

Collaborator

coveralls commented Mar 21, 2024 •

edited

Loading

coverage: 79.874%. remained the same
when pulling a3808f0 on roxx30198:tests_gdb
into 611a597 on IntelPython:main.

ZzEeKkAa force-pushed the tests_gdb branch from 51f45bb to 96f9271 Compare

March 21, 2024 17:42

ZzEeKkAa changed the title ~~WIP: Corrected gdb tests failing and corrected examples.~~ Organize gdb tests

ZzEeKkAa changed the title ~~Organize gdb tests~~ Simplify and organize gdb tests

ZzEeKkAa self-requested a review

March 22, 2024 18:34

Contributor

ZzEeKkAa commented Mar 22, 2024

I've pushed some commits on top of it to simplify and organize gdb tests

ZzEeKkAa previously approved these changes

View reviewed changes

ZzEeKkAa marked this pull request as ready for review

March 22, 2024 18:43

roxx30198 and others added 8 commits

March 22, 2024 14:43


          Update gdb-oneapi to 2024.0

459d467


          Removed skip_no_numba

41ecc1b


          Corrected gdb tests

ec2b770


          Avoid installing icpx compiler for gdb WF

cc3137c


          Shrink test input into one line

95a1b9f


          Remove wildcard from debugging/test_info and expect new dpnp device m…

9b25ee4

…odel


          Move common to gdb

3814f85


          Use gdb app yield

d21ae07

ZzEeKkAa force-pushed the tests_gdb branch from 8ca9b5c to 9208285 Compare

March 22, 2024 19:06

ZzEeKkAa dismissed their stale review via

d2450ae

March 22, 2024 19:13

ZzEeKkAa added 3 commits

March 22, 2024 16:17


          Simplify and organize gdb tests

ae4316b


          Add gdb logs

f2489c7


          Remove dpctl.device_context from examples

a3808f0

ZzEeKkAa force-pushed the tests_gdb branch from c99d53d to a3808f0 Compare

March 22, 2024 20:17

ZzEeKkAa self-requested a review

March 22, 2024 20:22

ZzEeKkAa approved these changes

View reviewed changes

ZzEeKkAa enabled auto-merge

March 22, 2024 20:22

diptorupd approved these changes

View reviewed changes

Contributor

diptorupd left a comment

Thanks @ZzEeKkAa for reviving and @roxx30198 for starting the work.

ZzEeKkAa disabled auto-merge

March 22, 2024 21:30

ZzEeKkAa merged commit 5245479 into IntelPython:main

51 of 63 checks passed

github-actions bot added a commit that referenced this pull request


          Merge pull request #1224 from roxx30198/tests_gdb

d89d8f8

Simplify and organize gdb tests 5245479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests