Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/index function overloads #1323

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Feature/index function overloads #1323

merged 1 commit into from
Feb 9, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Feb 8, 2024 •
edited
Loading

Add more index function overloads:

  • Update nd_item.get_global_id/item.get_id to generate SPIRV, not OpenCL specific instruction
  • Add nd_item.get_local_id overload
  • Add item.get_range, item.get_local_range, item.get_global_range with overloads.

Checklist:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Related: #274

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd February 8, 2024 05:20
@ZzEeKkAa ZzEeKkAa self-assigned this Feb 8, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/index_function_overloads branch 2 times, most recently from 7f4ee66 to 9b2ad84 Compare February 8, 2024 17:01
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review February 8, 2024 17:02
@ZzEeKkAa ZzEeKkAa force-pushed the feature/index_function_overloads branch from 9b2ad84 to f925bd2 Compare February 8, 2024 18:04
diptorupd
diptorupd approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Great changes

@diptorupd diptorupd force-pushed the feature/index_function_overloads branch from 597e148 to f10454b Compare February 8, 2024 23:13
@ZzEeKkAa ZzEeKkAa force-pushed the feature/index_function_overloads branch 2 times, most recently from 02f5c77 to 6562cc4 Compare February 9, 2024 02:40
@ZzEeKkAa ZzEeKkAa force-pushed the feature/index_function_overloads branch from 6562cc4 to 31e1205 Compare February 9, 2024 02:55
@ZzEeKkAa ZzEeKkAa enabled auto-merge February 9, 2024 03:04
@ZzEeKkAa ZzEeKkAa merged commit d4118df into main Feb 9, 2024
47 of 56 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/index_function_overloads branch February 9, 2024 03:35
github-actions bot added a commit that referenced this pull request Feb 9, 2024
@github-actions
Merge pull request #1323 from IntelPython/feature/index_function_over…
e23aa7c 
…loads

Feature/index function overloads d4118df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd