Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_SYSTEM_LIBUSB does not exists in lrs_options.cmake #3024

Closed
oiramario opened this issue Jan 8, 2019 · 12 comments
Closed

USE_SYSTEM_LIBUSB does not exists in lrs_options.cmake #3024

oiramario opened this issue Jan 8, 2019 · 12 comments
Assignees

Comments

@oiramario
Copy link

oiramario commented Jan 8, 2019

The default settings of wiki "Build Customization Flags" are not synchronized with lrs_options.

@dorodnic
Copy link
Contributor

dorodnic commented Jan 9, 2019

Updated, thanks :)
Build-Configuration

@oiramario
Copy link
Author

oiramario commented Jan 10, 2019

Thanks~ Glad to see your update!
However, there are 30 macros in Build-Configuration and 26 macros in lrs_options.cmake.

Build-Configuration------------------------------lrs_options.cmake
BUILD_PYTHON_MATLAB------------------------mismatch BUILD_MATLAB_BINDINGS
DOTNET_VERSION_EXAMPLES------------------missing
DOTNET_VERSION_LIBRARY---------------------missing
BUILD_CV_KINFU_EXAMPLES--------------------missing
INTERNAL_FW_SOURCE-------------------------missing
USE_SYSTEM_LIBUSB----------------------------missing
CMAKE_BUILD_TYPE-----------------------------ignore

@dorodnic
Copy link
Contributor

Yes, we should try to collect everything into lrs_options.cmake.
Recent Cmake refactor was a big step forward IMHO, and I certainly don't want to go back to the spaghetti Cmake we used to have until recently.

@oiramario
Copy link
Author

(。•̀ᴗ-)✧

@RealSenseCustomerSupport
Copy link
Collaborator

[Please Ignore - RealSense system comment]

2 similar comments
@RealSenseCustomerSupport
Copy link
Collaborator

[Please Ignore - RealSense system comment]

@RealSenseCustomerSupport
Copy link
Collaborator

[Please Ignore - RealSense system comment]

@oiramario
Copy link
Author

pls add USE_SYSTEM_LIBUSB into lrs_options.cmake, because:
screenshot from 2019-01-24 02-16-30

macro--------------------------------Build-Configuration----------lrs_options.cmake
BUILD_WITH_OPENMP------------------true------------------------------off
USE_SYSTEM_LIBUSB -------------------true------------------------------missing

@claudiofantacci
Copy link
Contributor

I'm also interested in having USE_SYSTEM_LIBUSB as ExternalProject_Add(libusb ...) custom target sometimes fails on windowsusing Ninja build with

fatal: could not create work tree dir 'libusb': Permission denied
fatal: could not create work tree dir 'libusb': Permission denied
fatal: could not create work tree dir 'libusb': Permission denied
-- Had to git clone more than once:
          3 times.
CMake Error at C:/Users/cfantacci/GitHub/librealsense/buildprova/libusb-prefix/tmp/libusb-gitclone.cmake:66 (message):
  Failed to clone repository: 'https://github.com/libusb/libusb.git'

To workaround this problem you just need to run ninja twice. I tried to had a look into it, but found no solution.

@RealSenseCustomerSupport
Copy link
Collaborator


@dorodnic Do we have any plan to include USE_SYSTEM_LIBUSB option?

@RealSenseCustomerSupport
Copy link
Collaborator


@oiramario Could you please check the latest SDK v2.26? lrs_options.cmake and the related wiki doc are updated. Looking forward to your feedback. Thanks!

@RealSenseCustomerSupport
Copy link
Collaborator


@oiramario If no other questions, will close this accordingly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants