Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fisheye distortion model in C# wrapper #5721

Closed
laguerreche opened this issue Jan 27, 2020 · 3 comments
Closed

Adding fisheye distortion model in C# wrapper #5721

laguerreche opened this issue Jan 27, 2020 · 3 comments
Labels

Comments

@laguerreche
Copy link

In SDK 2.32.1, the C# wrapper still doesn't expose the fisheye Kannala Brandt distortion model. Could you add it to Distortion.cs file? In the enum, it would take value 5.

Example:

namespace Intel.RealSense
{
    /// <summary>
    /// Distortion model: defines how pixel coordinates should be mapped to sensor coordinates.
    /// </summary>
    public enum Distortion
    {
        /// <summary> Rectilinear images. No distortion compensation required.</summary>
        None = 0,

        /// <summary> Equivalent to Brown-Conrady distortion, except that tangential distortion is applied to radially distorted points</summary>
        ModifiedBrownConrady = 1,

        /// <summary> Equivalent to Brown-Conrady distortion, except undistorts image instead of distorting it</summary>
        InverseBrownConrady = 2,

        /// <summary> F-Theta fish-eye distortion model</summary>
        Ftheta = 3,

        /// <summary> Unmodified Brown-Conrady distortion model</summary>
        BrownConrady = 4,

        FisheyeKannalaBrandt = 5
    }
}
@RealSenseCustomerSupport
Copy link
Collaborator


Thank you for your contribution.

There is the PR. #5853

@dorodnic dorodnic added the .NET label Feb 17, 2020
@RealSenseCustomerSupport
Copy link
Collaborator


@laguerreche PR#5853 has been merged to the latest v2.34. Please have a check. Thanks!

#5853

@RealSenseCustomerSupport
Copy link
Collaborator


@laguerreche Did you get chance to try? Looking forward to your update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants