From 25f2f784d2d9ed886f68556d227a9ff2d50b8128 Mon Sep 17 00:00:00 2001
From: Andrea Brighi <andrea.brighi8@studio.unibo.it>
Date: Wed, 12 Jul 2023 00:16:19 +0200
Subject: [PATCH] fix(reminder): change return type for method
 getBooksForLesson and getLessonsForBook, both now return ReminderForLesson

---
 .../reminderdomain/entitites/Reminder.kt              |  8 ++++----
 .../entitites/implementation/ReminderImpl.kt          | 11 +++++++----
 2 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/Reminder.kt b/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/Reminder.kt
index 61002899..6c4b4ebb 100644
--- a/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/Reminder.kt
+++ b/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/Reminder.kt
@@ -41,17 +41,17 @@ interface Reminder {
      * Get books for lesson.
      *
      * @param event event.
-     * @return books for lesson.
+     * @return the reminder for lesson.
      */
-    fun getBooksForLesson(event: EventAdapter.CalendarEvent): Set<String>
+    fun getBooksForLesson(event: EventAdapter.CalendarEvent): Set<ReminderForLesson>
 
     /**
      * Get lessons for book.
      *
      * @param isbn isbn.
-     * @return lessons for book.
+     * @return the reminder for the book.
      */
-    fun getLessonsForBook(isbn: String): Set<EventAdapter.CalendarEvent>
+    fun getLessonsForBook(isbn: String): Set<ReminderForLesson>
 
     /**
      * Get books for lesson in date.
diff --git a/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/implementation/ReminderImpl.kt b/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/implementation/ReminderImpl.kt
index 0fdfac67..6655682d 100644
--- a/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/implementation/ReminderImpl.kt
+++ b/reminderDomain/src/main/kotlin/com/intelligentbackpack/reminderdomain/entitites/implementation/ReminderImpl.kt
@@ -7,6 +7,9 @@ import java.time.LocalDate
 
 /**
  * Reminder implementation
+ *
+ * @param booksForLesson map of books for lesson
+ * @param lessonsForBook map of lessons for book
  */
 data class ReminderImpl(
     val booksForLesson: Map<EventAdapter.CalendarEvent, Set<ReminderForLesson>> = mapOf(),
@@ -109,12 +112,12 @@ data class ReminderImpl(
         )
     }
 
-    override fun getBooksForLesson(event: EventAdapter.CalendarEvent): Set<String> {
-        return booksForLesson[event]?.map { it.isbn }?.toSet() ?: setOf()
+    override fun getBooksForLesson(event: EventAdapter.CalendarEvent): Set<ReminderForLesson> {
+        return booksForLesson[event]?.toSet() ?: setOf()
     }
 
-    override fun getLessonsForBook(isbn: String): Set<EventAdapter.Lesson> {
-        return lessonsForBook[isbn]?.map { it.lesson }?.toSet() ?: setOf()
+    override fun getLessonsForBook(isbn: String): Set<ReminderForLesson> {
+        return lessonsForBook[isbn]?.toSet() ?: setOf()
     }
 
     override fun getBooksForLessonInDate(event: EventAdapter.CalendarEvent, date: LocalDate): Set<String> {