Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npu): support npu fusion rotary mul #187

Merged

Conversation

SolenoidWGT
Copy link
Contributor

@SolenoidWGT SolenoidWGT commented Apr 9, 2024

Motivation

Support npu fusion rotary mul,use API is torch_npu.npu_rotary_mul.
Ref: npu_rotary_mul

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@SolenoidWGT SolenoidWGT force-pushed the feat/support_torchnpu_fused_rope_new_2 branch from 3316ad7 to 461df2a Compare April 9, 2024 09:11
@SolenoidWGT SolenoidWGT force-pushed the feat/support_torchnpu_fused_rope_new_2 branch from 461df2a to ae65766 Compare April 9, 2024 09:22
@sunpengsdu sunpengsdu merged commit bd80f06 into InternLM:develop May 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants