Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support Nemo #2094

Open
lihan opened this issue Jul 21, 2024 · 4 comments
Open

[Feature] support Nemo #2094

lihan opened this issue Jul 21, 2024 · 4 comments
Assignees

Comments

@lihan
Copy link

lihan commented Jul 21, 2024

Motivation

The best multilingual open source small LM.

https://mistral.ai/news/mistral-nemo/

Related resources

No response

Additional context

No response

@zhyncs
Copy link
Collaborator

zhyncs commented Jul 21, 2024

The structure is essentially the same as that of a Llama, supporting it shouldn't be too difficult, please stay tuned. ref https://github.com/vllm-project/vllm/pull/6548/files

@maxin9966
Copy link

@zhyncs Does it support the AWQ format?

@AllentDan
Copy link
Collaborator

AllentDan@d14ce34

I found that mistral and llama used different input_dim for attention.output layer. Do we need another type or name argument to distinguish the model architecture? @lvhan028 @lzhangzz
https://github.com/huggingface/transformers/blob/main/src/transformers/models/mistral/modeling_mistral.py#L199
https://github.com/huggingface/transformers/blob/main/src/transformers/models/llama/modeling_llama.py#L303

@lzhangzz
Copy link
Collaborator

The input dim of attention.output should be computed as head_num * head_dim. The use of hidden_units_ is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants