Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on hjsonschema #286

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Remove dependency on hjsonschema #286

merged 1 commit into from
Dec 24, 2024

Conversation

abailly
Copy link
Contributor

@abailly abailly commented Dec 12, 2024

This is needed for #285

@abailly
Copy link
Contributor Author

abailly commented Dec 12, 2024

/cc @erikd

erikd
erikd requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abailly Looks good, but would like to see a minimal diff. There seem to have been a bunch un-needed of formatting changes in this PR.

@abailly
Copy link
Contributor Author

abailly commented Dec 19, 2024

My bad, I have autoformatting on with fourmolu.

@abailly abailly force-pushed the abailly/remove-hjsonschema branch from a05902f to 0e4781c Compare December 19, 2024 06:14
@abailly abailly requested a review from erikd December 19, 2024 06:35
erikd
erikd approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thanks.

@erikd
Copy link
Contributor

erikd commented Dec 19, 2024

@paweljakubas Would appreciate it if you could also review.

paweljakubas
paweljakubas approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable and good to me

@paweljakubas paweljakubas merged commit 231ecb2 into IntersectMBO:master Dec 24, 2024
7 checks passed
@paweljakubas paweljakubas deleted the abailly/remove-hjsonschema branch December 24, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@erikd erikd erikd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abailly @erikd @paweljakubas