Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trySubmitTx_ from ImpTest should also optionally run conformance #4725

Closed
aniketd opened this issue Oct 28, 2024 · 1 comment · Fixed by #4748
Closed

trySubmitTx_ from ImpTest should also optionally run conformance #4725

aniketd opened this issue Oct 28, 2024 · 1 comment · Fixed by #4748
Assignees
@aniketd
Labels
conformance conway 🕵️ testing

Comments

@aniketd
Copy link
Contributor

aniketd commented Oct 28, 2024

This will need changes to ImpTestEnv and a "hook", similar to fixup perhaps. This will help us run the existing ImpTests to also check conformance.
@aniketd aniketd added this to Conway Oct 28, 2024
@aniketd aniketd self-assigned this Oct 28, 2024
@aniketd aniketd converted this from a draft issue Oct 28, 2024
@lehins
Copy link
Collaborator

lehins commented Oct 28, 2024

similar to fixup perhaps

To be more specific, similar to iteFixup, not fixupTx

@Soupstraw Soupstraw mentioned this issue Nov 13, 2024
Open
This was referenced Nov 21, 2024
Open
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Conway Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aniketd aniketd

Labels
conformance conway 🕵️ testing
Projects
Chang+1 Ledger Conformance Testing
Status: Done
Conway
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Conformance.Imp: imptests with conformance IntersectMBO/cardano-ledger
2 participants
@aniketd @lehins