Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of crypto parametrization #4788

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Get rid of crypto parametrization #4788

merged 5 commits into from
Dec 15, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Dec 6, 2024 •
edited by lehins
Loading

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky
Copy link
Contributor Author

Opened a draft PR, since now it's a good time to discuss a few things and then we can proceed with cleaning up the commit history, resolving conflicts etc.

@Lucsanszky Lucsanszky force-pushed the lehins/get-rid-of-crypto-parametrization branch from 4db5713 to 05ab36c Compare December 9, 2024 16:55
@Lucsanszky Lucsanszky marked this pull request as ready for review December 9, 2024 17:09
@Lucsanszky Lucsanszky requested a review from a team as a code owner December 9, 2024 17:09
@Lucsanszky
Copy link
Contributor Author

Marking this ready for review.

A few things that still needs to be done:

  • Remove extraneous specialisations
  • Maybe run hlint --refactor as a rebase script to remove some extra parenthesis leftovers

@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch 2 times, most recently from 6a283af to c0de4cb Compare December 10, 2024 03:37
@lehins lehins mentioned this pull request Dec 10, 2024
Closed
8 tasks
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from ef07c87 to 008df29 Compare December 11, 2024 02:28
@lehins lehins changed the base branch from master to tdammers/for-mlocked-kes-consensus December 11, 2024 02:31
@lehins lehins mentioned this pull request Dec 11, 2024
Open
Lucsanszky
Lucsanszky commented Dec 11, 2024
View reviewed changes
Copy link
Contributor Author

@Lucsanszky Lucsanszky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review progress tracker:

  • eras:
    • shelley
    • allegra
    • mary
    • alonzo
    • shelley-ma
    • babbage
    • conway 👍
  • libs:
    • cardano-ledger-api
    • cardano-ledger-conformance
    • cardano-ledger-core
    • cardano-ledger-test
    • cardano-protocol-tpraos
    • ledger-state

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from e8b1adb to d0cb5c5 Compare December 11, 2024 19:44
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch 2 times, most recently from 2d2d735 to 03a7111 Compare December 11, 2024 21:59
@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch from 210f7d6 to 26784d7 Compare December 11, 2024 22:12
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from 03a7111 to 6876f1b Compare December 11, 2024 22:13
@lehins
Copy link
Collaborator

lehins commented Dec 12, 2024

I've reviewed the whole PR.
Now we just need to wait for #4699 to be merged.

@lehins lehins force-pushed the tdammers/for-mlocked-kes-consensus branch 2 times, most recently from e446454 to 92007c1 Compare December 14, 2024 14:31
Base automatically changed from tdammers/for-mlocked-kes-consensus to master December 14, 2024 16:39
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from 4905a02 to e7868d1 Compare December 14, 2024 19:10
lehins
lehins approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #4699 is merged we can proceed with merging this PR.

This was a massive piece of work. Thank you @Lucsanszky and @aniketd for working on this!

@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch 2 times, most recently from 5a75b75 to f35ca52 Compare December 14, 2024 19:35
@lehins lehins enabled auto-merge December 15, 2024 00:02
@lehins lehins disabled auto-merge December 15, 2024 00:04
lehins and others added 4 commits December 14, 2024 17:05
@lehins @aniketd
Remove crypto parametrization
7449147 
We only retain KES and VRF parametrization, which is applicable to block
headers. This means that HASH, ADDRHASH and DSIGN were switched from a
type family to a type synonym for a concrete algorithm. This allowed us
to remove crypto paramterization from all eras and ledger related types.

Co-authored-by: Daniel Lucsanszky <daniel.lucsanszky@iohk.io>

Co-authored-by: Aniket Deshpande <aniket.deshpande@iohk.io>
@lehins
Add new CHANGELOG section to cardano-ledger-byron-test
2481ce0 
This is needed as the postprocess step for recent release
@lehins
Bump up the heap limit for shelley-test
509555c
@lehins
Fix Arbitrary instance for Credential
5343fd8
@lehins lehins force-pushed the lehins/get-rid-of-crypto-parametrization branch from a632238 to 5343fd8 Compare December 15, 2024 00:07
@lehins lehins enabled auto-merge December 15, 2024 00:07
@lehins lehins merged commit 8855c23 into master Dec 15, 2024
153 of 154 checks passed
@lehins lehins deleted the lehins/get-rid-of-crypto-parametrization branch December 15, 2024 02:03
lehins added a commit that referenced this pull request Dec 19, 2024
@lehins
Move Crypto class and StandardCrypto to protocol-tpraos
1ff2f3e 
Since #4788 `Crypto` and `StandardCrypto` only define `KES` and `VRF`,
which are primitives unused by ledger. For this reason they are now
being moved to `cardano-protocol-tpraos` package
lehins added a commit that referenced this pull request Dec 19, 2024
@lehins
Move Crypto class and StandardCrypto to protocol-tpraos
49504f5 
Since #4788 `Crypto` and `StandardCrypto` only define `KES` and `VRF`,
which are primitives unused by ledger. For this reason they are now
being moved to `cardano-protocol-tpraos` package
lehins added a commit that referenced this pull request Dec 19, 2024
@lehins
Move Crypto class and StandardCrypto to protocol-tpraos
b6ff1e9 
Since #4788 `Crypto` and `StandardCrypto` only define `KES` and `VRF`,
which are primitives unused by ledger. For this reason they are now
being moved to `cardano-protocol-tpraos` package
lehins added a commit that referenced this pull request Dec 20, 2024
@lehins
Move Crypto class and StandardCrypto to protocol-tpraos
bdad5de 
Since #4788 `Crypto` and `StandardCrypto` only define `KES` and `VRF`,
which are primitives unused by ledger. For this reason they are now
being moved to `cardano-protocol-tpraos` package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucsanszky @lehins