-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support registration certificates #19
base: main
Are you sure you want to change the base?
Conversation
(C.StakeAddrRegistrationPreConway C.ShelleyToBabbageEraBabbage stakeCred) | ||
tx = | ||
E.emptyTxBodyContent | ||
{ C.txCertificates = C.TxCertificates C.shelleyBasedEra [stakeCert] (C.BuildTxWith mempty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-iohk It feels weird that this validates: an empty BuildTxWith and no extra witnesses needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be the case pre cardano-node-8.8. It appears to be fixed from 8.8.
I appreciate you spending the time on this! I tried using this PR's code to see if I could now execute a staking script but I could not. While the registration transaction now successfully goes through, I now get the following error when I withdraw 0 ADA:
I get this error even if the staking script is not registered. Were you able to execute a staking script? |
@fallen-icarus No. A quick look at what this errors means suggests that the emulator would have to maintain delegation state to get this to work. Unfortunately I no longer work on the emulator (nor anyone else), so this looks like a dead end for now. |
7344c78
to
8923ffd
Compare
@fallen-icarus I'm getting the chance to work a bit longer on the emulator! And maintaining the delegation state didn't seem too hard to do. If you want you can try your scripts again! |
It seems to be working now! Thank you! |
@fallen-icarus Thanks for verifying so quickly, that's really helpful! |
Fixes #18
Pre-submit checklist: