Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of "out of bounds" error in CLI #2063

Closed
mkoura opened this issue Nov 5, 2020 · 0 comments · Fixed by #2079
Closed

Better handling of "out of bounds" error in CLI #2063

mkoura opened this issue Nov 5, 2020 · 0 comments · Fixed by #2079
Labels
bug Something isn't working cli revision is used to group all the Node CLI tickets comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee

Comments

@mkoura
Copy link
Contributor

mkoura commented Nov 5, 2020

Internal

Summary
Currently for txout that is out of bounds the error message returned from cardano-cli is like

cardano-cli: out of bounds : 18446744073709551616
CallStack (from HasCallStack):
error, called at src/Shelley/Spec/Ledger/Coin.hs:85:7 in shelley-spec-ledger-0.1.0.0-IeGFDbbu6DOEY21tDs0yyj:Shelley.Spec.Ledger.Coin

More polished and descriptive error message would be useful.

Steps to reproduce
Steps to reproduce the behavior:

  1. build transaction with out of bounds txout, like
cardano-cli shelley transaction build-raw --ttl 3200 --fee 200000 --out-file out_of_bounds_tx.body --tx-in 6a017fb98f0271be10c586555dffe7d31d3ec2187ced6ce048a8e4eb6466535b#0 --tx-out addr_test1vqnw3llcedvjr25yvzz7p03nmzqdwcd79q53ul6d6dkn7vqv597tu+2800000 --tx-out addr_test1vp6hgc3ysfj802vhydsauvr7p95rtsluvvw2msgnmue55jcl30mzf+18446744073709551616

Expected behavior
Polished and descriptive error message.

System info (please complete the following information):

  • OS: Fedora
  • Version 32
  • Node version 04a6731
@mkoura mkoura added the cli revision is used to group all the Node CLI tickets label Nov 5, 2020
@dcoutts dcoutts added the bug Something isn't working label Nov 5, 2020
@iohk-bors iohk-bors bot closed this as completed in 7a709d7 Dec 8, 2020
@dorin100 dorin100 added type: bug Something is not working user type: internal Created by an IOG employee comp: cardano-cli labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli revision is used to group all the Node CLI tickets comp: cardano-cli type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants