Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - misleading error message when --upper-bound is used together with --ttl #2189

Closed
mkoura opened this issue Dec 7, 2020 · 2 comments
Closed
Labels
bug Something isn't working comp: networking type: bug Something is not working user type: internal Created by an IOG employee

Comments

@mkoura
Copy link
Contributor

mkoura commented Dec 7, 2020

Internal

Summary
If --upper-bound is used together with --ttl when building transaction, the error message makes it seem like the --upper-bound option doesn't exist:

$ cardano-cli shelley transaction build-raw --ttl 19150 --fee 324429 --out-file test_script_time_locking_from_tx.body --tx-in b0edd77252ee0132de869c47874fc5c2b20191f44bf20b5864b6a09edf7ad1a4#0 --tx-out addr_test1vzhx8649xq8yx69xrykct5300zep8ryje50nygu52pkqscql0396f+1000 --tx-out addr_test1wrqdlyzgtv5t6zukr43zpwg7y8f2yrvac3qrdl38ps2c0kgt4up88+1674571 --lower-bound 101 --upper-bound 17225 --allegra-era
Invalid option `--upper-bound'

Usage: cardano-cli (COMMAND | Byron specific commands | Miscellaneous commands)

Same error message is printed for any non-existent option:

$ cardano-cli transaction build-raw --fee 324429 --out-file test_script_time_locking_from_tx.body --tx-in b0edd77252ee0132de869c47874fc5c2b20191f44bf20b5864b6a09edf7ad1a4#0 --tx-out addr_test1vzhx8649xq8yx69xrykct5300zep8ryje50nygu52pkqscql0396f+1000 --tx-out addr_test1wrqdlyzgtv5t6zukr43zpwg7y8f2yrvac3qrdl38ps2c0kgt4up88+1674571 --not-exist 17225 --allegra-era
Invalid option `--not-exist'

Usage: cardano-cli (COMMAND | Byron specific commands | Miscellaneous commands)

Steps to reproduce
Steps to reproduce the behavior:

  1. prepare script address with funds
  2. try to spend from the script address using both --ttl and --upper-bound options
  3. See error

Expected behavior
An error message that indicates that --ttl and --upper-bound options cannot be used together.

System info (please complete the following information):

  • OS: Fedora
  • Version 32
  • Node version 196ba71
@mkoura mkoura added the bug Something isn't working label Dec 7, 2020
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Dec 7, 2020

The deprecated command --ttl was not hidden in the cli and probably led to incorrectly specifying --ttl and --upper-bound which are the same thing. I've hidden the deprecated commands in #2190.

@dcoutts
Copy link
Contributor

dcoutts commented Dec 7, 2020

Fixed in #2190.

@dcoutts dcoutts closed this as completed Dec 7, 2020
@dorin100 dorin100 added type: bug Something is not working user type: internal Created by an IOG employee comp: networking labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp: networking type: bug Something is not working user type: internal Created by an IOG employee
Projects
None yet
Development

No branches or pull requests

4 participants