Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix (change request) #2378 #22

Merged
merged 16 commits into from
Nov 26, 2024
Merged

Bugfix (change request) #2378 #22

merged 16 commits into from
Nov 26, 2024

Conversation

nebojsact
Copy link
Contributor

List of changes

  • Change
  • Change a way how address and ampunt are stored for treasury proposal
  • Removed atributes: prop_receiving_address and prop_amount
  • Added array object: proposal_withdrawals
  • Change a version of package to 0.5.0

Checklist

  • related issue
  • [ x ] My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

djordje-git and others added 15 commits September 18, 2024 13:14
@djordje-git
workflows
11c55d3
@vpaunovic
Merge pull request #6 from IntersectMBO/dev
445b2c9 
Dev
@vpaunovic
Merge pull request #7 from IntersectMBO/qa
93f96f1
@vpaunovic
Merge pull request #8 from IntersectMBO/pre-prod
6655705 
Pre prod
@teske00
Merge pull request #9 from IntersectMBO/docs/add-missing-files
56a21b2 
Docs/add missing files
@vpaunovic
Merge pull request #11 from IntersectMBO/dev
20de071 
from DEV to QA
@vpaunovic
Merge pull request #12 from IntersectMBO/qa
8455f6d 
from QA to PRE-PROD
@vpaunovic
Merge pull request #13 from IntersectMBO/pre-prod
e8c7bf3 
Pre prod
@nebojsajsimic
Merge pull request #15 from IntersectMBO/dev
5792b18 
From Dev to QA - 12.11.2024
@nebojsajsimic
Merge pull request #16 from IntersectMBO/qa
9637ea7 
From QA to PRE PROD - 12.11.2024
@nebojsajsimic
Merge pull request #17 from IntersectMBO/pre-prod
6cd1f0f 
From Pre prod to Main - 12.11.2024
@nebojsajsimic
Merge pull request #20 from IntersectMBO/dev
1e85545 
From QA to PreProd BugFix #2242
@nebojsajsimic
Merge pull request #21 from IntersectMBO/pre-prod
83d81c0 
From PreProd to Main BugFix #2242
@nebojsajsimic
This change allows users to add up to 10 different addresses when sub…
5692d97 
…mitting a proposal.
@nebojsajsimic
Version changed to 5.0
7e1ffb4
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

teske00
teske00 approved these changes Nov 26, 2024
View reviewed changes
pdf-ui/src/index.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes from this file, uncomment BrowserRouter

pdf-ui/src/components/EditProposalDialog/index.jsx Outdated
@@ -402,7 +325,7 @@ const EditProposalDialog = ({
useEffect(() => {
setDraft(setDraftData(proposal));
}, [proposal]);

console.log(draft);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

pdf-ui/src/components/EditProposalDialog/index.jsx Outdated
const setDraftData = (proposalData) => {
console.table(proposalData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.table

@teske00 teske00 merged commit c8c8520 into dev Nov 26, 2024
1 check passed
@teske00 teske00 deleted the Bugfix-(change-request)-#2378 branch November 26, 2024 08:03
@github-actions GitHub Actions
Copy link

@nebojsact
This PR is in the tag: dev-c8c8520d7f06c7a9319ad9bff6b8cede7c8269d1 , for backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teske00 teske00 teske00 approved these changes

@vpaunovic vpaunovic Awaiting requested review from vpaunovic vpaunovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nebojsact @teske00 @djordje-git @vpaunovic @nebojsajsimic