Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When submitting a DRep Registration, the transaction does not contain a vote delegation to self #1211

Closed
Ryun1 opened this issue Jun 9, 2024 · 2 comments · Fixed by #1227
Assignees

Comments

@Ryun1
Copy link
Member

Ryun1 commented Jun 9, 2024

Context & versions

  • When registering as a DRep from any role (Direct Voter, No Role, Delegator)
  • The transaction never contains a vote delegation to self

Actual behavior

when i change from; Direct Voter -> DRep, all GovTool does is submit a DRep Update certificate
when I go from; retired DRep -> Direct Voter, GovTool does a DRep registration AND a Vote Delegation
when I go from; retired DRep -> DRep, GovTool does a DRep registration

when I go from; no role -> DRep, GovTool does a DRep registration AND is missing the delegation

Expected behavior

  • When moving from No Role -> DRep, the transaction SHOULD also contain a Vote Delegation to self.
  • When moving from the Retired state, NO delegation is fine as it is expect that the user is still delegated to self

Sketch of intended behaviour

image

@MSzalowski
Copy link
Contributor

That is an awesome explanation of the flow, we'll do that

@MSzalowski MSzalowski moved this to In progress in Govtool all Jun 10, 2024
@MSzalowski MSzalowski moved this from In progress to To do in Govtool all Jun 10, 2024
@Sworzen1 Sworzen1 moved this from To do to In progress in Govtool all Jun 10, 2024
@Sworzen1 Sworzen1 moved this from In progress to In review in Govtool all Jun 10, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Jun 11, 2024
@Sworzen1 Sworzen1 removed their assignment Jun 11, 2024
@Sworzen1 Sworzen1 moved this from Done to In QA in Govtool all Jun 11, 2024
@pmbinapps pmbinapps self-assigned this Jun 11, 2024
@pmbinapps
Copy link

Recheck when fixed:
Dashboard, DRep metadata validation: after Retirement, and when a user is a Direct Voter - DRep metadata are shown as missing #1254

@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Jun 17, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants