Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard, DRep explorer, DRep details - DRep name appears beyond label #1253

Closed
pmbinapps opened this issue Jun 11, 2024 · 3 comments · Fixed by #1259
Closed

Dashboard, DRep explorer, DRep details - DRep name appears beyond label #1253

pmbinapps opened this issue Jun 11, 2024 · 3 comments · Fixed by #1259
Labels
🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link

pmbinapps commented Jun 11, 2024 •
edited
Loading

To reproduce:

  1. Register DRep with 80 chars long no space name
  2. Go to Dashboard
  3. Go to DRep explorer
  4. Go to DRep details

Results is as on image blow:

Image

Image

Image
@pmbinapps pmbinapps converted this from a draft issue Jun 11, 2024
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Jun 11, 2024
@pmbinapps pmbinapps changed the title Dashboard, DRep explorer - DRep name appears beyond label Dashboard, DRep explorer, DRep details - DRep name appears beyond label Jun 11, 2024
@MSzalowski MSzalowski moved this to To do in Govtool all Jun 12, 2024
@Sworzen1 Sworzen1 moved this from To do to In review in Govtool all Jun 12, 2024
Sworzen1 added a commit that referenced this issue Jun 12, 2024
@Sworzen1
#1253 add ellipsize text for drep name
d7b34d1
@Sworzen1 Sworzen1 mentioned this issue Jun 12, 2024
Merged
5 tasks
@Sworzen1 Sworzen1 linked a pull request Jun 12, 2024 that will close this issue
fix/1253-dashboard-drep-explorer-drep-details-drep-name-appears-beyond-label #1259
Merged
5 tasks
Sworzen1 added a commit that referenced this issue Jun 12, 2024
@Sworzen1
#1253 improvement
51b956b 
Signed-off-by: Bartlomiej Sworzen <b.sworzen@gmail.com>
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Jun 12, 2024
@Sworzen1 Sworzen1 moved this from Done to In QA in Govtool all Jun 12, 2024
@Sworzen1 Sworzen1 removed their assignment Jun 12, 2024
@pmbinapps pmbinapps mentioned this issue Jun 12, 2024
Merged
@pmbinapps
Copy link
Author

OK NOW - Jam record

@MSzalowski MSzalowski mentioned this issue Jun 13, 2024
Merged
@MSzalowski MSzalowski moved this from In QA to In staging in Govtool all Jun 13, 2024
@m-i-k-e
Copy link

m-i-k-e commented Jun 13, 2024 •
edited
Loading

If you put in a really long name - 80 characters, then you will generate a really long URL, and in this case, this failed because the url was over 128 characters long.

https://www.loom.com/share/9b3eeffcc06246ae95a6ce5236dcc4ba?sid=87cd9079-d02c-491f-9bc1-2a3691ff2023

image

@m-i-k-e m-i-k-e reopened this Jun 13, 2024
@m-i-k-e
Copy link

m-i-k-e commented Jun 13, 2024

@MSzalowski

@m-i-k-e m-i-k-e mentioned this issue Jun 13, 2024
Open
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@Ryun1 Ryun1 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/1253-dashboard-drep-explorer-drep-details-drep-name-appears-beyond-label IntersectMBO/govtool
4 participants
@m-i-k-e @Ryun1 @Sworzen1 @pmbinapps