Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for hardfork phases and network #1530

Closed
4 tasks done
spannercode opened this issue Jul 9, 2024 · 4 comments
Closed
4 tasks done

Testing for hardfork phases and network #1530

spannercode opened this issue Jul 9, 2024 · 4 comments

Comments

@spannercode
Copy link
Contributor

spannercode commented Jul 9, 2024

Why

We want to have smooth transition of the hard fork phases on the govtool and ensure that nothing breaks

What

  • Testing for the hardfork phases based on the protocol version
  • Testing the network compatibility

How

For this, we need to the following information from the backend (or wallet (does not seem possible atm))

  • Network tip
  • protocol version
  • Network name/id

With information, we need to update the tests to enable conditional checks on the tests. This involves which gov actions are currently valid for the current protocol version and whether or not the govtool has addressed that sufficiently.
This also involves setup stage of test confirming the wallet is inline with the network the backend is configured for.

Dependency

  • Backend API provides protocol version, network tip information
  • Govtool frontend is updated to check for wallet network and backend network
  • Govtool frontend is updated to react according to the protocol version. Eg. enabling/disabling certain gov actions.
  • References to hard coded SanchoNet should be removed with network name obtained from backend or the wallet.
@MSzalowski
Copy link
Contributor

Network name under GET /network/metrics:
#1644

@MSzalowski
Copy link
Contributor

Milestone created by @Ryun1 that covers some of the points listed in Dependency secion.

@bosko-m bosko-m removed the DBSync5 label Aug 12, 2024
@Ryun1
Copy link
Member

Ryun1 commented Sep 12, 2024

this sorted @spannercode ?

@spannercode
Copy link
Contributor Author

@Ryun1 yes, it can be closed now.

@Ryun1 Ryun1 closed this as completed Sep 12, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Govtool all Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants