Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Incorrect representation for script-based DReps #1951

Closed
Ryun1 opened this issue Sep 5, 2024 · 4 comments
Closed

🐛 Incorrect representation for script-based DReps #1951

Ryun1 opened this issue Sep 5, 2024 · 4 comments
Assignees
Labels

Comments

@Ryun1
Copy link
Member

Ryun1 commented Sep 5, 2024

Area

Delegation Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

  • GovTool assumes all DReps read from chain are key-based, this is incorrect
  • Script-based DReps can be created via other tooling and then GovTool can read these from chain and show via the DRep directory
  • Script based DReps can be represented with a different bech32 encoding drep_script
  • Script-based DReps must be represented correctly at vote delegation time
  • this probably requires a change in BE API to flag Scripbased DReps as such

Steps to reproduce

  1. look up a script DRep: https://gov.tools/drep_directory/drep1uk4nwfsm843kqr2kv4jg0yms46srr633pzc2d0vvaav25ncwj8g
  2. see metadata

Actual behavior

  • DRep ID shown incorrectly in directory
  • Delegation is to the wrong DRep as keyHash is used instead of scriptHash

Expected behavior

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 5, 2024

Incorrect prefix is reported from the DB-Sync level

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 5, 2024

a start
#1956

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 12, 2024

duplicate to #921

@Ryun1 Ryun1 changed the title 🐛 Incorrect Bech32 representation for script-based DReps 🐛 Incorrect representation for script-based DReps Sep 13, 2024
@bosko-m bosko-m moved this from To do to In progress in Govtool all Sep 23, 2024
@bosko-m
Copy link
Contributor

bosko-m commented Oct 14, 2024

After the conversation with @Ryun1 today, we are putting P0 on this one.
@MSzalowski @jdyczka

jdyczka pushed a commit that referenced this issue Oct 21, 2024
jdyczka added a commit that referenced this issue Oct 21, 2024
@jdyczka jdyczka moved this from In progress to In review in Govtool all Oct 22, 2024
@MSzalowski MSzalowski moved this from In review to Done in Govtool all Oct 23, 2024
@bosko-m bosko-m closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Governance Tools Community Backlog Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants