🐛 Duplicate Test IDs for DRep Links and Identity Reference Field Errors

[kneerose]

Area

Delegation Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

Test IDs for all fields should be unique to ensure accurate testing and identification. Currently, the test IDs for the error messages related to description, URL of links, and identity fields are duplicated (e.g., invalid-url-error and max-80-characters-error). This issue also includes the overlap where the description error message shares a test ID with one of the name error messages i.e max-80-characters-error. Therefore, distinct test IDs are required for each error message to avoid confusion and ensure proper testing.

Steps to reproduce

1. Connect to the wallet.
2. Navigate to the /register_dRep page.
3. Observe the test IDs for the error messages related to description andURL, of identity and links reference

Actual behavior

Test IDs for the error messages of description, and URL, of identity and links reference are duplicated, which may lead to confusion during testing.

Expected behavior

Each error message should have a unique test ID to ensure clear and accurate testing.

[spannercode]

@jdyczka Here is the ticket for missing test-ids.

[jdyczka]

@spannercode Right now test ids for inputs are generated automatically based on the error message. So in theory this can also affect other places where there are different fields, but with the same error message. The same applies to the hint below the input.
Maybe it would make more sense to generate test ids based on the test id of the input field? If done globally that would ensure uniqueness, however, it might also require a bunch of changes on your side.
Let me know if you would prefer me to go with the global approach, or just handle the case of link and identity references.

[spannercode]

To document it here, our recommendation would be to fix this specific case first so that we can working tests and properly refactor while unpacking the pillars.
CC: @jdyczka