Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA Display: Display on-chain data of governance actions #332

Closed
Thomas-Upfield opened this issue Feb 27, 2024 · 3 comments
Closed

GA Display: Display on-chain data of governance actions #332

Thomas-Upfield opened this issue Feb 27, 2024 · 3 comments

Comments

@Thomas-Upfield
Copy link

Thomas-Upfield commented Feb 27, 2024

milestone: https://github.com/IntersectMBO/govtool/milestone/12

User Story

As any user

I want to see the on chain data of a governance action displayed in the proper format.

So that I can read and understand it

Acceptance Criteria

Given that I am looking at the Governance Action page

When I click the View Details button of a specific Treasury Withdrawal governance action listed

Then I can see the on-chain details of the governance action in a format that is easy to read and not confusing.

Definition of Done

Any relevant on chain details are listed in an easy to read format on the page of that specific governance action

@MSzalowski
Copy link
Contributor

This has to be reviewed and ready for dev.

@Thomas-Upfield Thomas-Upfield changed the title Display on-chain data of governance actions GA Display: Display on-chain data of governance actions Mar 17, 2024
@m-i-k-e
Copy link

m-i-k-e commented Mar 18, 2024

So for info actions, there is no extra on-chain data. For treasury actions there should be an array of addresses and amounts. However, for simplicity, we have included only one address/amount pair. This a shortcut just so we don't block the designers and devs.

Here is the treasury actions page in Figma: https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=8762%3A61513&mode=design&t=XNvNQ9Dm6FHcqST5-1

@m-i-k-e
Copy link

m-i-k-e commented Mar 19, 2024

This is ready for dev in Figma, if that's a concern. Going forward, we will look in turn at the other GActions, and create pages according to what data is there. https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=8762%3A57449&mode=design&t=somTzusmTFKazuRe-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants