Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend package unit tests to github workflow #507

Closed
MSzalowski opened this issue Mar 19, 2024 · 2 comments
Closed

Add frontend package unit tests to github workflow #507

MSzalowski opened this issue Mar 19, 2024 · 2 comments
Assignees
@MSzalowski @pmbinapps
Milestone
Intersect - Open ...

Comments

@MSzalowski
Copy link
Contributor

Why

To gather quick feedback on failing tests. Which would help us deliver a better code.

What

Set up github action that should run tests on every pull request.

How

  • Using github workflow
  • Should be set on: push
  • Should run npm run test or yarn test on govtool/frontend package
  • Should use node-v18
@MSzalowski MSzalowski self-assigned this Mar 19, 2024
MSzalowski added a commit that referenced this issue Mar 19, 2024
@MSzalowski
[#507] feat: add frontend test github workflow
c94ae49 
Set up test_frontend workflow to dispatch automated tests on every pull request.
@MSzalowski MSzalowski mentioned this issue Mar 19, 2024
Merged
5 tasks
MSzalowski added a commit that referenced this issue Mar 19, 2024
@MSzalowski
[#507] chore: add frontend test github workflow
d472d90 
Set up test_frontend workflow to dispatch automated tests on every pull request.
MSzalowski added a commit that referenced this issue Mar 19, 2024
@MSzalowski
[#507] chore: change file name
4cda470
MSzalowski added a commit that referenced this issue Mar 19, 2024
@MSzalowski
Merge pull request #508 from IntersectMBO/feat/507/add-frontend-packa…
ffd1129 
…ge-unit-tests-to-github-workflow

[#507] feat: add frontend test github workflow
@MSzalowski
Copy link
Contributor Author

To QA:
To test that issue, check if any PR triggers the test_frontend.yml workflow.

@pmbinapps pmbinapps mentioned this issue Mar 20, 2024
Merged
@MSzalowski MSzalowski added this to the Open source preparation milestone Mar 21, 2024
@pmbinapps
Copy link

OK:
https://github.com/IntersectMBO/govtool/actions/runs/8357989547
https://github.com/IntersectMBO/govtool/actions/workflows/test_frontend.yml?query=branch%3Atest

Image

@pmbinapps pmbinapps self-assigned this Mar 22, 2024
@pmbinapps pmbinapps mentioned this issue Mar 25, 2024
Closed
@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@pmbinapps pmbinapps mentioned this issue Apr 4, 2024
Merged
@MSzalowski MSzalowski moved this to In staging in Govtool all Apr 8, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

@pmbinapps pmbinapps

Labels
None yet
Projects
Govtool all
Status: Done
Milestone
Intersect - Open source preparation
Development

No branches or pull requests
2 participants
@MSzalowski @pmbinapps