Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending transactions refactor #522

Closed
jdyczka opened this issue Mar 20, 2024 · 2 comments · Fixed by #523
Closed

Pending transactions refactor #522

jdyczka opened this issue Mar 20, 2024 · 2 comments · Fixed by #523
Labels
🖥 Frontend Frontend related 🔩 Tech debt

Comments

@jdyczka
Copy link
Contributor

jdyczka commented Mar 20, 2024

Extract all logic relating to pending transactions into a separate hook.
Review and simplify that logic.
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@j-dyczka
[#522] extract transaction state logic to hook
2a0e70f
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@j-dyczka
[#522] refactor useTransactions hook
662a581
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@j-dyczka
[#522] check if DBSync updated after transaction
4bfdb16
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@Sworzen1 @j-dyczka
[#522] delete unnecessary code
0f0d73c
@jdyczka jdyczka mentioned this issue Mar 20, 2024
Merged
5 tasks
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@j-dyczka @Sworzen1
[#522] refactor useTransactions hook
e3851e3 
Co-authored-by: Bartłomiej Sworzeń <b.sworzen@gmail.com>
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@j-dyczka
[#522] check if DBSync updated after transaction
55f6477
jdyczka pushed a commit that referenced this issue Mar 20, 2024
@Sworzen1 @j-dyczka
[#522] delete unnecessary code
48a585e
@Sworzen1 Sworzen1 linked a pull request Mar 20, 2024 that will close this issue
[#522] chore: refactor pending transaction #523
Merged
5 tasks
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@j-dyczka
[#522] extract transaction state logic to hook
93fdd8b
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@j-dyczka @Sworzen1
[#522] refactor useTransactions hook
3707aed 
Co-authored-by: Bartłomiej Sworzeń <b.sworzen@gmail.com>
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@j-dyczka
[#522] check if DBSync updated after transaction
5fb7fd2
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@Sworzen1 @j-dyczka
[#522] delete unnecessary code
210d91c
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@Sworzen1 @j-dyczka
[#522] delete unnecessary code
66ebbc6
jdyczka pushed a commit that referenced this issue Mar 22, 2024
@Sworzen1 @j-dyczka
[#522] delete unnecessary code
467460f
jdyczka added a commit that referenced this issue Mar 22, 2024
@jdyczka
Merge pull request #523 from IntersectMBO/transaction-state
22448dd 
[#522] chore: refactor pending transaction
@pmbinapps pmbinapps mentioned this issue Mar 25, 2024
Merged
jdyczka pushed a commit that referenced this issue Mar 25, 2024
@j-dyczka
[#522] fix bugs in usePendingTransaction
e261c80
jdyczka pushed a commit that referenced this issue Mar 25, 2024
@j-dyczka
[#522] fix bugs in usePendingTransaction
bb26945
@jdyczka jdyczka mentioned this issue Mar 25, 2024
Merged
5 tasks
jdyczka pushed a commit that referenced this issue Mar 26, 2024
@j-dyczka
[#522] fix pending transaction expiration logic
302a82d
jdyczka pushed a commit that referenced this issue Mar 26, 2024
@j-dyczka
[#522] fix pending transaction expiration logic
874755f
jdyczka pushed a commit that referenced this issue Mar 26, 2024
@j-dyczka
[#522] fix pending transaction expiration logic
28d782c
jdyczka added a commit that referenced this issue Mar 26, 2024
@jdyczka
Merge pull request #553 from IntersectMBO/transaction-state
bc5665d 
[#522] fix bugs in usePendingTransaction
jdyczka pushed a commit that referenced this issue Mar 26, 2024
@j-dyczka
[#522] fix reading pending transaction from localStorage
ed5ebe0
@jdyczka jdyczka mentioned this issue Mar 26, 2024
Merged
5 tasks
jdyczka pushed a commit that referenced this issue Mar 26, 2024
@j-dyczka @jdyczka
[#522] fix reading pending transaction from localStorage
6d59394
@pmbinapps pmbinapps self-assigned this Mar 26, 2024
@pmbinapps
Copy link

Just appeared new situation (was fine up apx noon):
All transactions are ended but info about Pending transactions is shown:

Image

Jam recording here

Other:

  • was working after Hard Reload and Refresh - now it is not

TO CHECK after merge to test and deploy...

@pmbinapps pmbinapps mentioned this issue Mar 26, 2024
Merged
@pmbinapps
Copy link

OK NOW after deploy - state processed correctly.

@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@pmbinapps pmbinapps mentioned this issue Apr 4, 2024
Merged
@MSzalowski MSzalowski moved this to Done in Govtool all Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🖥 Frontend Frontend related 🔩 Tech debt
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#522] chore: refactor pending transaction IntersectMBO/govtool
3 participants
@jdyczka @Sworzen1 @pmbinapps