Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA Display: Display Warning if Metadata is not in the Expected Format #535

Closed
Thomas-Upfield opened this issue Mar 21, 2024 · 3 comments · Fixed by #598
Closed

GA Display: Display Warning if Metadata is not in the Expected Format #535

Thomas-Upfield opened this issue Mar 21, 2024 · 3 comments · Fixed by #598
Assignees
@Sworzen1 @pmbinapps
Milestone
Byron - GA Displa...

Comments

@Thomas-Upfield
Copy link

No description provided.

Sworzen1 added a commit that referenced this issue Mar 29, 2024
@Sworzen1
[#535] check governance actions are valid
c91efd0
@Sworzen1 Sworzen1 linked a pull request Mar 29, 2024 that will close this issue
feat/535-ga-display-display-warning-if-metadata-is-not-in-the-expected-format #598
Merged
5 tasks
@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@pmbinapps pmbinapps self-assigned this Apr 2, 2024
@pmbinapps
Copy link

OK Design
OK Text

Not matching data info available:

OK on GA card list
NOT OK on GA View all -
OK on GA card details

@pmbinapps
Copy link

OK NOW:

https://test-sanchonet.govtool.byron.network/connected/governance_actions/b95f2aa3dffcf9e4f286cd0260853dd0016c52a6f441081321bce6f34b73a67a#0
Image

https://test-sanchonet.govtool.byron.network/connected/governance_actions/38e700d9b6a6a7da1fdcc46cc7968f2dae11b2f5021a5c5732c5097fc30bce2c#0
Image

@pmbinapps
Copy link

https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=9398-151307&mode=design&t=ICp04Cri8qboOVe5-4

OK for all cases:

Image

NOTE: Verification is not instant if a change appears in json data.

@MSzalowski MSzalowski moved this from Done to In staging in Govtool all Apr 8, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sworzen1 Sworzen1

@pmbinapps pmbinapps

Labels
None yet
Projects
Govtool all
Status: Done
Milestone
Byron - GA Display: Display Warning i...
Development

Successfully merging a pull request may close this issue.

feat/535-ga-display-display-warning-if-metadata-is-not-in-the-expected-format IntersectMBO/govtool
3 participants
@Sworzen1 @pmbinapps @Thomas-Upfield