Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BT] DRep registration doesn't finish. (80 chars long title not cut, not submittitng) #655

Closed
m-i-k-e opened this issue Apr 5, 2024 · 2 comments · Fixed by #692
Closed

[BT] DRep registration doesn't finish. (80 chars long title not cut, not submittitng) #655

m-i-k-e opened this issue Apr 5, 2024 · 2 comments · Fixed by #692
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented Apr 5, 2024

Context & versions

staging.sanchonet; Demos 1.7

Video

https://www.loom.com/share/efffe5bdceb14f4c920f4f569030b0db?sid=92b94338-7560-41ea-a943-0f0fd5281d78

Steps to reproduce

  1. Try to become a DRep
  2. Go to end of flow and click "Submit"

Actual behavior

nothing happens

Expected behavior

Registration is complete

Other Issues

  1. Url field needs to return over in download button
  2. Error messages need to be more friendlier
@MSzalowski MSzalowski added the 🐛 Bug Something isn't working label Apr 8, 2024
@pmbinapps
Copy link

pmbinapps commented Apr 8, 2024 •
edited
Loading

For Bug Triage issues to fix:

  • Url validation less string should accept eg. "microsoft.com" - without "https://"
    image
  • Showing very long json file name - not handled
    image
  • Submitting such long file name is not working - WORK AROUND - shorten file name

@pmbinapps pmbinapps changed the title DRep registration doesn't finish. [BT] DRep registration doesn't finish. (80 chars long title not cut, not submittitng) Apr 8, 2024
@MSzalowski MSzalowski moved this to To do in Govtool all Apr 9, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Apr 10, 2024
@MSzalowski MSzalowski self-assigned this Apr 10, 2024
MSzalowski added a commit that referenced this issue Apr 11, 2024
@MSzalowski
[#655] fix: fix DRep registration when the DRep name is longer
9f2d5ab
@MSzalowski MSzalowski linked a pull request Apr 11, 2024 that will close this issue
[#655] fix: fix DRep registration when the DRep name is longer #692
Merged
5 tasks
@MSzalowski MSzalowski mentioned this issue Apr 11, 2024
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Apr 11, 2024
MSzalowski added a commit that referenced this issue Apr 15, 2024
@MSzalowski
Merge pull request #692 from IntersectMBO/fix/655-bt-drep-registratio…
773c9ca 
…n-doesnt-finish-80-chars-long-title-not-cut-not-submittitng

[#655] fix: fix DRep registration when the DRep name is longer
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Apr 15, 2024
@MSzalowski MSzalowski moved this from Done to In QA in Govtool all Apr 15, 2024
@pmbinapps pmbinapps mentioned this issue Apr 19, 2024
Merged
@MSzalowski MSzalowski mentioned this issue Apr 19, 2024
Merged
@pmbinapps
Copy link

OK NOW:
used json file:
https://raw.githubusercontent.com/mpawel79/testrepo/master/test_test_test_t.jsonld

@pmbinapps pmbinapps self-assigned this Apr 25, 2024
@pmbinapps pmbinapps mentioned this issue Apr 25, 2024
Merged
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Apr 26, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#655] fix: fix DRep registration when the DRep name is longer IntersectMBO/govtool
4 participants
@m-i-k-e @MSzalowski @JanJaroszczak @pmbinapps