Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padding on buttons too small on DRep list #878

Closed
m-i-k-e opened this issue Apr 26, 2024 · 4 comments · Fixed by #892
Closed

padding on buttons too small on DRep list #878

m-i-k-e opened this issue Apr 26, 2024 · 4 comments · Fixed by #892
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented Apr 26, 2024

Context & versions

staging.sanchnoet

Steps to reproduce

  1. Go to Drep List
  2. Look at buttons

Loom Video

https://www.loom.com/share/29143157de9946108b88e44f9b43a279?sid=bf6f9deb-72ff-4924-87ce-478230e01130
If not reproducible, describe the steps you took as you remember it.

Actual behavior

Buttons' padding does not match Figma

Expected behavior

Buttons' padding should match figma
@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label Apr 26, 2024
@MSzalowski MSzalowski moved this to To do in Govtool all Apr 29, 2024
@pmbinapps
Copy link

Image

Image

@Sworzen1 Sworzen1 moved this from To do to In progress in Govtool all Apr 30, 2024
@vercia vercia mentioned this issue Apr 30, 2024
Merged
5 tasks
@Sworzen1 Sworzen1 assigned Sworzen1 and vercia and unassigned Sworzen1 Apr 30, 2024
@vercia vercia linked a pull request Apr 30, 2024 that will close this issue
fix/878-change-padding-on-button #892
Merged
5 tasks
@Sworzen1 Sworzen1 moved this from In progress to In review in Govtool all Apr 30, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Apr 30, 2024
@Sworzen1 Sworzen1 moved this from Done to In QA in Govtool all Apr 30, 2024
@Sworzen1 Sworzen1 mentioned this issue May 6, 2024
Closed
@pmbinapps
Copy link

OK padding on buttons
NOT OK - small misalignment on Active and View details, Delegate buttons

Additional:

View details button background should be white

Image

@pmbinapps pmbinapps moved this from In QA to To do in Govtool all May 9, 2024
@MSzalowski MSzalowski reopened this May 13, 2024
@MSzalowski
Copy link
Contributor

@pmbinapps Please reopen issues that are going back after QAs verification

@JanJaroszczak JanJaroszczak self-assigned this May 13, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all May 13, 2024
@JanJaroszczak JanJaroszczak removed their assignment May 13, 2024
@MSzalowski MSzalowski moved this from In progress to In QA in Govtool all May 15, 2024
@pmbinapps
Copy link

OK NOW - slight difference, but most of columns of data synced with Figma

Image

@pmbinapps pmbinapps self-assigned this May 15, 2024
@pmbinapps pmbinapps mentioned this issue May 16, 2024
Merged
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all May 16, 2024
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@Ryun1 Ryun1 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/878-change-padding-on-button IntersectMBO/govtool
7 participants
@m-i-k-e @vercia @MSzalowski @Ryun1 @Sworzen1 @JanJaroszczak @pmbinapps