Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegating to No confidence still shows DRep delegation for a while, Automated Voting options 'accordion' is closed, should be open. #919

Closed
m-i-k-e opened this issue May 1, 2024 · 7 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented May 1, 2024

Context & versions

staging.sanchonet

Steps to reproduce

  1. Delegate to a Drep
  2. Delegate to No Confidence

Actual behavior vs expected behaviour

  1. Delegation starts and
  2. The interface still shows (while delegation is in progress) that you are delegated to a Drep. This should disappear as soon as the user presses the delegate button
  3. When a user is delegated to Abstain or No confidence, the 'combo' box that contains these options should be open. This also should apply when the delegation is in progress.

Expected behavior

As above, also see loom video.

Loom video

https://www.loom.com/share/c652a0543a534c4dafcf2396cc918500?sid=4981ff20-9f4b-4dd3-a837-26b6766347cb

@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label May 1, 2024
@pmbinapps
Copy link
Contributor

pmbinapps commented May 2, 2024

Two visual aspect mentioned in loop:

  • Automated Voting option card should stay unfolded after delegation (@Sworzen1)
  • If You have delegate do a DRep and change to No or Abstain this card should be updated earlier - please refer to loom for details (@MSzalowski - this looks like part of handling transaction status and presenting transition between various delegation options)

Image

@MSzalowski MSzalowski moved this to To do in Govtool all May 7, 2024
@MSzalowski
Copy link
Contributor

@m-i-k-e In that case could you please clarify a bit states of this badges (when they should be displayed and why)
Based on the issue and figma design.

@MSzalowski MSzalowski moved this from To do to Backlog in Govtool all May 7, 2024
@pmbinapps
Copy link
Contributor

The interface still shows (while delegation is in progress) that you are delegated to a Drep.
OK NOW :This should disappear as soon as the user presses the delegate button

TODO: When a user is delegated to Abstain or No confidence, the 'combo' box that contains these options should be open.
This also should apply when the delegation is in progress.

@MSzalowski MSzalowski moved this from Backlog to To do in Govtool all May 9, 2024
@JanJaroszczak JanJaroszczak self-assigned this May 10, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all May 10, 2024
@JanJaroszczak
Copy link
Contributor

Fully fixed with this PR: #1013

@JanJaroszczak JanJaroszczak moved this from In progress to In review in Govtool all May 13, 2024
@MSzalowski MSzalowski moved this from In review to In QA in Govtool all May 15, 2024
@pmbinapps
Copy link
Contributor

OK NOW:

  • Delegation card disappears when Abstain, No confidance chosen
  • Abstain - No confidance is unfolded when a delegation is in progress or activated

Jam recording

@pmbinapps pmbinapps assigned pmbinapps and unassigned JanJaroszczak May 15, 2024
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all May 16, 2024
@MSzalowski
Copy link
Contributor

@pmbinapps Should that still be assigned to you?

@m-i-k-e
Copy link
Author

m-i-k-e commented Jun 11, 2024

@m-i-k-e m-i-k-e closed this as completed Jun 11, 2024
@github-project-automation github-project-automation bot moved this from In staging to Done in Govtool all Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants