Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting Power not correct on Automated options, picking up user's voting power #932

Closed
m-i-k-e opened this issue May 2, 2024 · 3 comments · Fixed by #1012
Closed

Voting Power not correct on Automated options, picking up user's voting power #932

m-i-k-e opened this issue May 2, 2024 · 3 comments · Fixed by #1012
Assignees
@JanJaroszczak @pmbinapps
Labels
🐛 Bug Something isn't working 🖥 Frontend Frontend related

Comments

@m-i-k-e
Copy link

m-i-k-e commented May 2, 2024

Context & versions

staging.sanchonet

Steps to reproduce

  1. Delegate to a Drep
  2. go to Drep directory
  3. Open combo box for automated voting options

Video:

https://www.loom.com/share/ce393cc15f24469685c34f1dd61eacf1?sid=4c6c2a4e-882f-4c6b-aec9-e05ab032ed7a

Actual behavior

Automated and Vote no shows user's own voting power in their "voting power" fields

Expected behavior

Automated and Vote should show the accumulated Voting Power that's been delegated to these options from all users of the system
@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label May 2, 2024
@pmbinapps
Copy link

Wrong Voting power value shown - should total votaing power instead users only:

Image

Could be related to this issue of correctly obtaining Voting power from db-sync

@MSzalowski MSzalowski moved this to To do in Govtool all May 9, 2024
@MSzalowski
Copy link
Contributor

MSzalowski commented May 10, 2024 •
edited
Loading

Frontend issue:

These values should be taken from GET /network/metrics

@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label May 10, 2024
@JanJaroszczak JanJaroszczak self-assigned this May 13, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all May 13, 2024
JanJaroszczak added a commit that referenced this issue May 13, 2024
@JanJaroszczak
[#932] Automated voting options voting power fix
7fd51e9
JanJaroszczak added a commit that referenced this issue May 13, 2024
@JanJaroszczak
[#932] Automated voting options voting power fix
c9788e5
@JanJaroszczak JanJaroszczak moved this from In progress to In review in Govtool all May 13, 2024
@JanJaroszczak JanJaroszczak mentioned this issue May 13, 2024
Merged
5 tasks
@JanJaroszczak JanJaroszczak linked a pull request May 13, 2024 that will close this issue
[#932] Automated voting options voting power fix #1012
Merged
5 tasks
JanJaroszczak added a commit that referenced this issue May 14, 2024
@JanJaroszczak
Merge pull request #1012 from IntersectMBO/932-voting-power-not-corre…
a6d6060 
…ct-on-automated-options-picking-up-users-voting-power

[#932] Automated voting options voting power fix
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 14, 2024
@JanJaroszczak JanJaroszczak moved this from Done to In QA in Govtool all May 14, 2024
@pmbinapps
Copy link

OK NOW, - Voting power on Automated options

Image

@pmbinapps pmbinapps self-assigned this May 14, 2024
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all May 16, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanJaroszczak JanJaroszczak

@pmbinapps pmbinapps

Labels
🐛 Bug Something isn't working 🖥 Frontend Frontend related
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#932] Automated voting options voting power fix IntersectMBO/govtool
5 participants
@m-i-k-e @MSzalowski @JanJaroszczak @jankun4 @pmbinapps