Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1028] fix: remove incorrectly appended filter yourself to drep directory #1029

Merged
merged 1 commit into from
May 15, 2024
Merged

[#1028] fix: remove incorrectly appended filter yourself to drep directory #1029

merged 1 commit into from
May 15, 2024

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented May 15, 2024 •
edited
Loading

List of changes

  • Filter yourself was incorrectly appended. This PR filters it out making the DRep directory filter match the requirements.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue May 15, 2024 that may be closed by this pull request
DRep directory - incorrectly appended filter "Yourself" to DRep directory #1028
Closed
@MSzalowski MSzalowski force-pushed the fix/1028-drep-directory-incorrectly-appended-filter-yourself-to-drep-directory branch from b1033c5 to 348ece0 Compare May 15, 2024 08:40
@MSzalowski MSzalowski merged commit 02d88d6 into develop May 15, 2024
4 of 5 checks passed
@MSzalowski MSzalowski deleted the fix/1028-drep-directory-incorrectly-appended-filter-yourself-to-drep-directory branch May 15, 2024 08:47
@pmbinapps pmbinapps mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRep directory - incorrectly appended filter "Yourself" to DRep directory
2 participants
@MSzalowski @Sworzen1