Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/extended tests #1033

Merged
merged 11 commits into from
May 16, 2024
Merged

Feat/extended tests #1033

merged 11 commits into from
May 16, 2024

Conversation

NabinKawan
Copy link
Contributor

List of changes

  • Added extended test cases
  • Fixed delegation timeout issue
  • Fixed formatting issue

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip May 16, 2024 01:16
@NabinKawan NabinKawan mentioned this pull request May 16, 2024
Closed
10 tasks
@mesudip mesudip changed the base branch from test to develop May 16, 2024 02:59
@mesudip mesudip requested review from placek, adgud and jankun4 as code owners May 16, 2024 02:59
@spannercode spannercode marked this pull request as draft May 16, 2024 03:44
@spannercode
Copy link
Contributor

@NabinKawan Could you please rebase the PR?

@NabinKawan NabinKawan force-pushed the feat/extended-tests branch from 34b598d to d516bd6 Compare May 16, 2024 05:11
@NabinKawan NabinKawan marked this pull request as ready for review May 16, 2024 05:17
mesudip
mesudip approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesudip mesudip merged commit 899edbe into develop May 16, 2024
5 of 7 checks passed
@mesudip mesudip deleted the feat/extended-tests branch May 16, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@placek placek Awaiting requested review from placek

@adgud adgud Awaiting requested review from adgud

@jankun4 jankun4 Awaiting requested review from jankun4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NabinKawan @spannercode @mesudip