Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Add tests for missing APIs #1036

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix/Add tests for missing APIs #1036

merged 1 commit into from
May 19, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented May 16, 2024

List of changes

  • Fix old tests
  • Update API response schema
  • Add tests for new apis

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@mesudip mesudip marked this pull request as ready for review May 19, 2024 06:47
@mesudip mesudip requested review from Ryun1 and MSzalowski as code owners May 19, 2024 06:47
@mesudip mesudip requested a review from NabinKawan May 19, 2024 07:14
NabinKawan
NabinKawan approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesudip mesudip merged commit 3387462 into develop May 19, 2024
1 check passed
@mesudip mesudip deleted the chore/fix-backend-tests branch May 19, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @NabinKawan