Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default cardano_api_metadata host url #1074

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: Default cardano_api_metadata host url #1074

merged 1 commit into from
May 23, 2024

Conversation

NabinKawan
Copy link
Contributor

List of changes

  • Resolved the metadata bucket URL issue
    Link to the report

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip May 23, 2024 04:23
@NabinKawan NabinKawan force-pushed the fix/upload-metadata branch from 4c6c46c to 33af884 Compare May 23, 2024 09:54
NabinKawan
NabinKawan commented May 23, 2024
View reviewed changes
Copy link
Contributor Author

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mesudip mesudip merged commit ee9f104 into develop May 23, 2024
@mesudip mesudip deleted the fix/upload-metadata branch May 23, 2024 09:58
@pmbinapps pmbinapps mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @mesudip