From 9e5ebcb0fd48bee6ba90ec4c50f12a66036dfe43 Mon Sep 17 00:00:00 2001 From: Nabin Kawan Date: Thu, 6 Jun 2024 12:07:24 +0545 Subject: [PATCH 1/4] chore: Remove retries for 2E, and 2S --- .../delegationFunctionality.delegation.spec.ts | 11 +++-------- tests/govtool-frontend/playwright/tests/dRep.setup.ts | 4 ++-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts b/tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts index c2b1f8e90..5836c567b 100644 --- a/tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts +++ b/tests/govtool-frontend/playwright/tests/2-delegation/delegationFunctionality.delegation.spec.ts @@ -117,8 +117,6 @@ test.describe("Register DRep state", () => { let dRepPage: Page; let wallet: StaticWallet; - test.describe.configure({ retries: 3 }); - test.beforeEach(async ({ page, browser }) => { wallet = await walletManager.popWallet("registerDRep"); @@ -128,16 +126,16 @@ test.describe("Register DRep state", () => { wallet, enableStakeSigning: true, }); + + await dRepPage.goto("/"); + await dRepPage.waitForTimeout(2_000); // Waits to ensure the wallet-connection modal not interfere with interactions }); test("2E. Should register as Direct voter", async ({}, testInfo) => { test.setTimeout(testInfo.timeout + environments.txTimeOut); const dRepId = wallet.dRepId; - await dRepPage.goto("/"); await dRepPage.getByTestId("register-as-sole-voter-button").click(); - - await expect(dRepPage.getByTestId("continue-button")).toBeVisible(); await dRepPage.getByTestId("continue-button").click(); await expect( dRepPage.getByTestId("registration-transaction-submitted-modal") @@ -162,10 +160,7 @@ test.describe("Register DRep state", () => { test("2S. Should retire as a Direct Voter on delegating to another DRep", async ({}, testInfo) => { test.setTimeout(testInfo.timeout + environments.txTimeOut); - await dRepPage.goto("/"); await dRepPage.getByTestId("register-as-sole-voter-button").click(); - - await expect(dRepPage.getByTestId("continue-button")).toBeVisible(); await dRepPage.getByTestId("continue-button").click(); await expect( dRepPage.getByTestId("registration-transaction-submitted-modal") diff --git a/tests/govtool-frontend/playwright/tests/dRep.setup.ts b/tests/govtool-frontend/playwright/tests/dRep.setup.ts index 0fa9a07c2..9563c69b6 100644 --- a/tests/govtool-frontend/playwright/tests/dRep.setup.ts +++ b/tests/govtool-frontend/playwright/tests/dRep.setup.ts @@ -7,8 +7,8 @@ import { expect, test as setup } from "@playwright/test"; import kuberService from "@services/kuberService"; import walletManager from "lib/walletManager"; -const REGISTER_DREP_WALLETS_COUNT = 9; -const DREP_WALLETS_COUNT = 9; +const REGISTER_DREP_WALLETS_COUNT = 8; +const DREP_WALLETS_COUNT = 7; setup.beforeEach(async () => { await setAllureEpic("Setup"); From 5184431b08a90e467d129761b8f3e2852a3daf8f Mon Sep 17 00:00:00 2001 From: Nabin Kawan Date: Thu, 6 Jun 2024 12:42:09 +0545 Subject: [PATCH 2/4] fix: Resolve balance issue in test case 2W --- tests/govtool-frontend/playwright/lib/constants/staticWallets.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts b/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts index db324bccf..f30c090d3 100644 --- a/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts +++ b/tests/govtool-frontend/playwright/lib/constants/staticWallets.ts @@ -22,6 +22,7 @@ export const adaHolderWallets = [ adaHolder03Wallet, adaHolder04Wallet, adaHolder05Wallet, + adaHolder06Wallet, ]; export const userWallets = [user01Wallet]; From aa1ec044b563ae8c0eb7520eb68c390539555741 Mon Sep 17 00:00:00 2001 From: Nabin Kawan Date: Thu, 6 Jun 2024 13:15:29 +0545 Subject: [PATCH 3/4] chore: Update temporary wallets count --- tests/govtool-frontend/playwright/tests/dRep.setup.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/govtool-frontend/playwright/tests/dRep.setup.ts b/tests/govtool-frontend/playwright/tests/dRep.setup.ts index 9563c69b6..a254f59c9 100644 --- a/tests/govtool-frontend/playwright/tests/dRep.setup.ts +++ b/tests/govtool-frontend/playwright/tests/dRep.setup.ts @@ -7,8 +7,8 @@ import { expect, test as setup } from "@playwright/test"; import kuberService from "@services/kuberService"; import walletManager from "lib/walletManager"; -const REGISTER_DREP_WALLETS_COUNT = 8; -const DREP_WALLETS_COUNT = 7; +const REGISTER_DREP_WALLETS_COUNT = 5; +const DREP_WALLETS_COUNT = 9; setup.beforeEach(async () => { await setAllureEpic("Setup"); From cb173e321216f0bccea57d1810aa08feeb753d33 Mon Sep 17 00:00:00 2001 From: Nabin Kawan Date: Thu, 6 Jun 2024 14:03:51 +0545 Subject: [PATCH 4/4] fix: Resolve wallet popup timeout issue in voting --- .../5-proposal-functionality/proposalFunctionality.dRep.spec.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts b/tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts index 411a5e8a4..55d401efa 100644 --- a/tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts +++ b/tests/govtool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts @@ -138,6 +138,8 @@ test.describe("Perform voting", () => { let dRepPage: Page; test.beforeEach(async ({ page, browser }) => { + test.slow(); // Due to queue in pop wallets + const wallet = await walletManager.popWallet("registeredDRep"); const tempDRepAuth = await createTempDRepAuth(page, wallet);