[#1195] Remove unnecessary deployment config dependancy #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the provided user story, the goal was to troubleshoot the failure in the Toggle Maintenance Page workflow by ensuring that all necessary environment variables are present. The acceptance criteria focused on identifying and setting the required environment variables for the workflow to run successfully. However, the commit candidate addresses this by removing the unnecessary creation and upload of the deployment config for the toggle-maintenance target. By simplifying the process and adjusting the workflow configuration, the changes aim to streamline the execution of the toggle maintenance page workflow and prevent potential errors caused by missing environment variables that are not really required.
MSzalowski
approved these changes
Jun 7, 2024
MSzalowski
deleted the
fix/1195-troubleshooting-failure-in-toggle-maintenance-page-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1195.
The PR optimizes the workflow by eliminating redundant steps, specifically related to the deployment config for the toggle-maintenance target. This adjustment simplifies the process, making it more straightforward and less prone to errors caused by unnecessary dependencies.