Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Storybook Testing with Additional and Refactored Tests #1240

Merged
merged 23 commits into from
Jun 12, 2024
Merged

Enhance Storybook Testing with Additional and Refactored Tests #1240

merged 23 commits into from
Jun 12, 2024

Conversation

NabinKawan
Copy link
Contributor

List of changes

  • Fixed/Refactored storybook tests
  • Added missing tests

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

NabinKawan added 23 commits June 11, 2024 15:52
@NabinKawan
fix: Theme provider issue in storybook
3519400
@NabinKawan
fix: ActionsBar interactions test
fc350fe
@NabinKawan
fix: test interaction loading button
7cc82db
@NabinKawan
Add interaction tests for card
a5da0ac
@NabinKawan
Add interaction tests for checkbox
6033b44
@NabinKawan
chore: Update DashboardTopNav interaction test
91fde96
@NabinKawan
chore: Update DelegationActionRadio interaction test
67d95c9
@NabinKawan
chore: Update footer interaction test
fa48c61
@NabinKawan
chore: Add interaction tests for (data-missing, format incorrect, not…
d8feb98 
… verifiable) proposal cards
@NabinKawan
test: Invalid GovernanceAction details
889e817
@NabinKawan
chore: refactor tests for Input story and add interaction for 'helpfu…
8b22deb 
…l text'
@NabinKawan
test: story LinkWithIcon
31c1d48
@NabinKawan
chore: test Slider component overflow
365d7b5
@NabinKawan
test: story StatusPill
9dd228b
@NabinKawan
test: story Step
3508c5c
@NabinKawan
test: story TextArea
a828db2
@NabinKawan
chore: Remove home-link in TopNav story
b07a830
@NabinKawan
test: story loading modal
be10f7e
@NabinKawan
test: story Voting Power Model
917e503
@NabinKawan
test: story dashboard card
789ac3b
@NabinKawan
chore: Increase interaction test timeout to 30 sec
5ff75a3
@NabinKawan
fix: story Footer interaction (feedback-footer-button)
39af694
@NabinKawan
chore: Remove helps-link test from Drawer story
b1badcc
@NabinKawan NabinKawan requested a review from mesudip June 11, 2024 10:11
@NabinKawan NabinKawan mentioned this pull request Jun 11, 2024
Closed
@NabinKawan NabinKawan merged commit 42a2be9 into develop Jun 12, 2024
3 of 4 checks passed
@NabinKawan NabinKawan deleted the feat/storybook-tests branch June 12, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @mesudip