Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/storybook workflow authtoken config #1241

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix/storybook workflow authtoken config #1241

merged 2 commits into from
Jun 12, 2024

Conversation

NabinKawan
Copy link
Contributor

List of changes

  • Setup npm config for pdf-ui in storybook workflow

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip June 11, 2024 10:45
@NabinKawan NabinKawan requested review from placek and adgud as code owners June 11, 2024 10:45
@NabinKawan NabinKawan mentioned this pull request Jun 11, 2024
Closed
mesudip
mesudip approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NabinKawan NabinKawan merged commit d359595 into develop Jun 12, 2024
1 check passed
@NabinKawan NabinKawan deleted the fix/storybook-workflow-authtoken-config branch June 12, 2024 07:22
@pmbinapps pmbinapps mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @mesudip