Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Incorrect dRep anchor URL and dataHash on dRep registration #1678

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Bug Fix: Incorrect dRep anchor URL and dataHash on dRep registration #1678

merged 4 commits into from
Aug 6, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Aug 6, 2024

List of changes

  • Upload randomly generated metadata to metadata-govtool and obtain the URL and its actual hash instead of using a hardcoded anchor URL and dataHash during dRep registration with kuber api.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested review from mesudip and removed request for MSzalowski, Sworzen1 and JanJaroszczak August 6, 2024 04:24
@kneerose kneerose merged commit 4ee15a2 into develop Aug 6, 2024
@kneerose kneerose deleted the bugfix/incorrect-dRep-metadata-url-hash branch August 6, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip