Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#1637): replace sanchonet in copy with voltaire #1684

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat(#1637): replace sanchonet in copy with voltaire #1684

merged 4 commits into from
Aug 7, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Replace sanchonet with voltaire
  • Consume network from get /network/metrics in order to make the GovTool network agnostic
  • Add dynamic link to cexplorer based on the network

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Aug 6, 2024 that may be closed by this pull request
Replace SanchoNet in copy with Voltaire #1637
Closed
@MSzalowski MSzalowski force-pushed the feat/1637-replace-sanchonet-in-copy-with-voltaire branch from bb2b647 to 4683985 Compare August 6, 2024 11:10
@MSzalowski MSzalowski force-pushed the feat/1637-replace-sanchonet-in-copy-with-voltaire branch from 4683985 to 35c14d7 Compare August 6, 2024 12:14
@MSzalowski MSzalowski requested review from m-i-k-e and jdyczka and removed request for Ryun1, Sworzen1 and JanJaroszczak August 6, 2024 12:18
@MSzalowski
Copy link
Contributor Author

@m-i-k-e Could you have a look on https://dev-sanchonet.govtool.byron.network/ and leave approval once the unsancho version of GovTool looks as expected?

This was referenced Aug 6, 2024
Closed
Closed
This was linked to issues Aug 6, 2024
Update in repository documentation to replace SanchoNet branding #1638
Closed
Rebrand SanchoNet to Voltaire #1640
Closed
[Bug] Preview GovTool points to SanchoNet blockexplorer #1682
Closed
@MSzalowski MSzalowski mentioned this pull request Aug 6, 2024
Closed
jdyczka
jdyczka approved these changes Aug 7, 2024
View reviewed changes
govtool/metadata-validation/src/main.ts Outdated Show resolved Hide resolved
@MSzalowski MSzalowski force-pushed the feat/1637-replace-sanchonet-in-copy-with-voltaire branch from 02e9c6a to 5a1d746 Compare August 7, 2024 11:40
@MSzalowski MSzalowski merged commit edc14ee into develop Aug 7, 2024
5 checks passed
@MSzalowski MSzalowski deleted the feat/1637-replace-sanchonet-in-copy-with-voltaire branch August 7, 2024 11:44
@m-i-k-e
Copy link

m-i-k-e commented Aug 8, 2024

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdyczka jdyczka jdyczka approved these changes

@m-i-k-e m-i-k-e Awaiting requested review from m-i-k-e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MSzalowski @m-i-k-e @jdyczka