Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1733): fix accessing drep deposit from possibly empty epoch params #1823

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix accessing DRep deposit from possibly empty epoch params

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Copy link

✅ All checks succeeded

2 similar comments
Copy link

✅ All checks succeeded

Copy link

✅ All checks succeeded

@@ -20,7 +20,7 @@ export const RolesAndResponsibilities = ({
const { t } = useTranslation();
const { isMobile } = useScreenDimension();

const deposit = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
const epochParams = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should probably add a return type to getItemFromLocalStorage, so that it's not implicitly any

@MSzalowski MSzalowski merged commit fe370fe into develop Aug 26, 2024
7 of 8 checks passed
@MSzalowski MSzalowski deleted the fix/1733-typeerror-cannot-read-properties-of-null-reading-drep_deposit branch August 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'drep_deposit')
2 participants