Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1733): fix accessing drep deposit from possibly empty epoch params #1823

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(#1733): fix accessing drep deposit from possibly empty epoch params #1823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ changes.
### Fixed

- Fix typescript bug leading to runtime error when entering Governance Action details page via direct link [Issue 1801](https://github.com/IntersectMBO/govtool/issues/1801)
- Fix accessing missing epochParams drep_deposit [Issue 1733](https://github.com/IntersectMBO/govtool/issues/1733)

### Changed

Expand Down
4 changes: 2 additions & 2 deletions govtool/frontend/src/components/organisms/RegisterAsDRepSteps/RolesAndResponsibilities.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const RolesAndResponsibilities = ({
const { t } = useTranslation();
const { isMobile } = useScreenDimension();

const deposit = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
const epochParams = getItemFromLocalStorage(PROTOCOL_PARAMS_KEY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should probably add a return type to getItemFromLocalStorage, so that it's not implicitly any


const onClickContinue = () => setStep(2);

Expand Down Expand Up @@ -51,7 +51,7 @@ export const RolesAndResponsibilities = ({
/>,
]}
i18nKey="registration.rolesAndResponsibilitiesDescription"
values={{ deposit: correctAdaFormat(deposit.drep_deposit) }}
values={{ deposit: correctAdaFormat(epochParams?.drep_deposit) }}
/>
</Typography>
<CenteredBoxBottomButtons
Expand Down
4 changes: 2 additions & 2 deletions govtool/frontend/src/context/wallet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,14 +651,14 @@ const CardanoProvider = (props: Props) => {
// Create cert object using one Ada as the deposit
dRepRegCert = DrepRegistration.new_with_anchor(
dRepCred,
BigNum.from_str(`${epochParams.drep_deposit}`),
BigNum.from_str(`${epochParams?.drep_deposit}`),
anchor,
);
} else {
console.error(t("errors.notUsingAnchor"));
dRepRegCert = DrepRegistration.new(
dRepCred,
BigNum.from_str(`${epochParams.drep_deposit}`),
BigNum.from_str(`${epochParams?.drep_deposit}`),
);
}
return Certificate.new_drep_registration(dRepRegCert);
Expand Down
2 changes: 1 addition & 1 deletion govtool/frontend/src/pages/RegisterAsDirectVoter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const RegisterAsDirectVoter = () => {
>
<Trans
i18nKey="directVoter.registerDescription"
values={{ deposit: correctAdaFormat(epochParams.drep_deposit) }}
values={{ deposit: correctAdaFormat(epochParams?.drep_deposit) }}
components={[
<Link
onClick={() => openInNewTab("https://sancho.network/")}
Expand Down
Loading