Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1866): fix formatting governance action id #1885

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(#1866): fix formatting governance action id #1885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1366e8
fix(#1866): fix formatting governance action id
MSzalowski Aug 30, 2024
556d6fc
fix(#1866): fix wrong test condition
MSzalowski Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ changes.
- Fix displaying non relevant data in protocol parameter change Governance Action [Issue 1601](https://github.com/IntersectMBO/govtool/issues/1601)
- Fix voting on info actions in bootstrapping phase [Issue 1876](https://github.com/IntersectMBO/govtool/issues/1876)
- Fix missing DRep name whitespace validation [Issue 1873](https://github.com/IntersectMBO/govtool/issues/1873)
- Fix displaying wrongly formatted Governance Action ID [Issue 1866](https://github.com/IntersectMBO/govtool/issues/1866k)

### Changed

Expand Down
5 changes: 3 additions & 2 deletions govtool/frontend/src/components/organisms/GovernanceActionDetailsCardData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
getProposalTypeLabel,
filterUpdatableProtocolParams,
filterOutNullParams,
getFullGovActionId,
} from "@utils";
import { MetadataValidationStatus, ProposalData } from "@models";
import { GovernanceActionType } from "@/types/governanceAction";
Expand Down Expand Up @@ -125,10 +126,10 @@ export const GovernanceActionDetailsCardData = ({
};

const label = getProposalTypeLabel(type);
const govActionId = `${index}${txHash}`;
const govActionId = getFullGovActionId(txHash, index);
const prevGovActionId =
prevGovActionIndex && prevGovActionTxHash
? `${prevGovActionIndex}${prevGovActionTxHash}`
? getFullGovActionId(prevGovActionTxHash, prevGovActionIndex)
: null;

const tabs = useMemo(
Expand Down
Loading