Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2277] fix: remove unneeded login step on workflow action #2347

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[2277] fix: remove unneeded login step on workflow action #2347

merged 2 commits into from
Nov 11, 2024

Conversation

Ryun1
Copy link
Member

@Ryun1 Ryun1 commented Nov 7, 2024 •
edited
Loading

List of changes

  • Overhaul action to use github personal access token and premade workflow template

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ryun1 Ryun1 requested review from placek and adgud as code owners November 7, 2024 13:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

@Ryun1 Ryun1 force-pushed the 2277-fix-failing-action branch from 9abaecb to ab6aa75 Compare November 7, 2024 13:54
@Ryun1 Ryun1 requested a review from MSzalowski as a code owner November 7, 2024 13:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

✅ All checks succeeded

@Ryun1
Copy link
Member Author

Ryun1 commented Nov 7, 2024

dont merge, im testing the via another repo

@Ryun1 Ryun1 marked this pull request as draft November 7, 2024 14:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

✅ All checks succeeded

@Ryun1 Ryun1 force-pushed the 2277-fix-failing-action branch from d7c9b21 to 892037f Compare November 11, 2024 11:13
@Ryun1 Ryun1 marked this pull request as ready for review November 11, 2024 11:14
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@Ryun1 Ryun1 merged commit ccdc17e into develop Nov 11, 2024
10 checks passed
@Ryun1 Ryun1 deleted the 2277-fix-failing-action branch November 11, 2024 11:58
@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-ccdc17ef119cc3b9c54f8da85ae0cd09d99382cd , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@Ryun1
This PR is in the tag: develop-ccdc17ef119cc3b9c54f8da85ae0cd09d99382cd , for govtool-metadata-validation service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryun1 @placek