Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2372): fix ada quantities format #2396

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(#2372): fix ada quantities format #2396

merged 1 commit into from
Nov 20, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix ada quantities format

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Nov 20, 2024 that may be closed by this pull request
🐛 ADA quantities format should avoid thousands when the total is 0 #2372
Closed
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek November 20, 2024 08:58
@MSzalowski MSzalowski force-pushed the fix/2372--ada-quantities-format-should-avoid-thousands-when-the-total-is-0 branch from 72644e2 to e27ab29 Compare November 20, 2024 14:05
@MSzalowski MSzalowski merged commit 1663f56 into develop Nov 20, 2024
10 checks passed
@MSzalowski MSzalowski deleted the fix/2372--ada-quantities-format-should-avoid-thousands-when-the-total-is-0 branch November 20, 2024 14:05
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-1663f5639db1f5533b7ede63d84119ce6c56ebae , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-1663f5639db1f5533b7ede63d84119ce6c56ebae , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-1663f5639db1f5533b7ede63d84119ce6c56ebae , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 ADA quantities format should avoid thousands when the total is 0
2 participants
@MSzalowski @placek