Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/governance dRep vote dependent test #2471

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Dec 5, 2024

List of changes

  • Navigate to first dRep vote eligible governance action instead of any governance action on full governance action to fix dRep vote dependent test
  • Parallize the bootstrap dRep vote test and improve the visibility checks for proper assertion
  • Fix governance action type typo
  • Add "vote-tab" assert to wait until the proposal is not visible

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Dec 5, 2024

✅ All checks succeeded

@kneerose kneerose merged commit 390a14b into develop Dec 5, 2024
3 checks passed
@kneerose kneerose deleted the bugfix/governance-dRep-vote-dependent-test branch December 5, 2024 10:02
Copy link

github-actions bot commented Dec 5, 2024

@kneerose
This PR is in the tag: develop-390a14beb52efd4ec60717d323301479e19d1546 , for govtool-frontend service

Copy link

github-actions bot commented Dec 5, 2024

@kneerose
This PR is in the tag: develop-390a14beb52efd4ec60717d323301479e19d1546 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants