Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Test IDs and Validate Add Withdrawal Address Button Visibility in Proposal Form #2488

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Update Test IDs and Validate Add Withdrawal Address Button Visibility in Proposal Form #2488

merged 2 commits into from
Dec 9, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Dec 9, 2024

List of changes

  • Update testId of receiving address and amount Input and error message
  • Add assertion on valid proposal form to test the add withdrawal address button visibility

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip December 9, 2024 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

mesudip
mesudip approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@kneerose kneerose merged commit 60a7bb1 into develop Dec 9, 2024
4 checks passed
@kneerose kneerose deleted the bugfix/proposal-test branch December 9, 2024 08:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@kneerose
This PR is in the tag: develop-60a7bb14ce702f5d1f53bfab7dd5442091f40063 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@kneerose
This PR is in the tag: develop-60a7bb14ce702f5d1f53bfab7dd5442091f40063 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip