Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2490): add registration cert when stake key is not registered #2491

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(#2490): add registration cert when stake key is not registered #2491

merged 1 commit into from
Dec 10, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • add registration cert when stake key is not registered

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Dec 9, 2024 that may be closed by this pull request
Failure on submitting the proposals with unregistered or registered (but wrongly handled by govtool) stake keys #2490
Open
@MSzalowski MSzalowski requested a review from placek December 9, 2024 15:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

@MSzalowski MSzalowski merged commit e073eb7 into develop Dec 10, 2024
8 checks passed
@MSzalowski MSzalowski deleted the fix/2490-failure-on-submitting-the-proposals-with-unregistered-or-registered-but-wrongly-handled-by-govtool-stake-keys branch December 10, 2024 03:21
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-e073eb7e69616cbac12f51bb6686051a98215618 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-e073eb7e69616cbac12f51bb6686051a98215618 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-e073eb7e69616cbac12f51bb6686051a98215618 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@MSzalowski @placek