Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal Draft Input Validation and Content Test Refactor #2492

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Proposal Draft Input Validation and Content Test Refactor #2492

merged 2 commits into from
Dec 10, 2024

Conversation

kneerose
Copy link
Contributor

List of changes

  • Add extra assertion on save proposal as a draft (save treasury proposal as a draft and validate the input value field of saved the draft)
  • Refactor proposal info content and update test Ids of receiving address content and amount content

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose
chore: add extra assertion on save proposal as a draft
a94ee13 
save treasury proposal as a draft and validate the input value inside the draft
@kneerose
refactor: proposal info content testIds
c4d77ee
@kneerose kneerose requested a review from mesudip December 10, 2024 06:40
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

mesudip
mesudip approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@kneerose kneerose merged commit d399787 into develop Dec 10, 2024
10 checks passed
@kneerose kneerose deleted the bugfix/proposal-test branch December 10, 2024 06:43
@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-d3997871e70413eb919e2c8bd36f4a09d2b32c24 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-d3997871e70413eb919e2c8bd36f4a09d2b32c24 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-d3997871e70413eb919e2c8bd36f4a09d2b32c24 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip